chore: Update external account schemas from webdev #152
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Greptile OverviewGreptile SummaryAuto-synced two new external account schemas from webdev for INR UPI and MXN SPEI payment corridors.
Confidence Score: 4/5
|
| Filename | Overview |
|---|---|
| openapi/components/schemas/external_accounts/ExternalAccountInfoOneOf.yaml | Added two new account types with formatting inconsistency in titles, plus indentation normalization |
| openapi/components/schemas/external_accounts/InrUpiAccountInfo.yaml | New INR UPI account schema with proper structure and validation |
| openapi/components/schemas/external_accounts/MxnSpeiAccountInfo.yaml | New MXN SPEI account schema with proper CLABE validation (18-digit pattern) |
Sequence Diagram
sequenceDiagram
participant WebDev as Webdev/Sparkcore
participant CopyBot as Copybara Sync Bot
participant GridAPI as Grid API Repo
participant OpenAPI as OpenAPI Schema
WebDev->>CopyBot: Generate external account schemas from VASP adapter
Note over WebDev: MxnSpeiAccountInfo schema<br/>InrUpiAccountInfo schema
CopyBot->>GridAPI: Auto-sync schemas
GridAPI->>OpenAPI: Add InrUpiAccountInfo.yaml
GridAPI->>OpenAPI: Add MxnSpeiAccountInfo.yaml
GridAPI->>OpenAPI: Update ExternalAccountInfoOneOf.yaml
Note over OpenAPI: Add INR_UPI_ACCOUNT mapping<br/>Add MXN_SPEI_ACCOUNT mapping<br/>Normalize indentation
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
Comment on lines
+34
to
+37
| - title: MxnSpeiAccountInfo | ||
| $ref: ./MxnSpeiAccountInfo.yaml | ||
| - title: InrUpiAccountInfo | ||
| $ref: ./InrUpiAccountInfo.yaml |
Contributor
There was a problem hiding this comment.
Inconsistent title format - should follow existing pattern like "SPEI Account" and "UPI Account" instead of schema names
Suggested change
| - title: MxnSpeiAccountInfo | |
| $ref: ./MxnSpeiAccountInfo.yaml | |
| - title: InrUpiAccountInfo | |
| $ref: ./InrUpiAccountInfo.yaml | |
| - title: SPEI Account | |
| $ref: ./MxnSpeiAccountInfo.yaml | |
| - title: INR UPI Account | |
| $ref: ./InrUpiAccountInfo.yaml |
Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!
Prompt To Fix With AI
This is a comment left during a code review.
Path: openapi/components/schemas/external_accounts/ExternalAccountInfoOneOf.yaml
Line: 34:37
Comment:
Inconsistent title format - should follow existing pattern like "SPEI Account" and "UPI Account" instead of schema names
```suggestion
- title: SPEI Account
$ref: ./MxnSpeiAccountInfo.yaml
- title: INR UPI Account
$ref: ./InrUpiAccountInfo.yaml
```
<sub>Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!</sub>
How can I resolve this? If you propose a fix, please make it concise.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Auto-synced external account schemas from webdev.
These schemas are generated from VASP adapter field definitions in sparkcore.
Please review the changes before merging.